Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable file fixes #276

Merged
merged 1 commit into from
Oct 5, 2023
Merged

disable file fixes #276

merged 1 commit into from
Oct 5, 2023

Conversation

dana-yaish
Copy link
Contributor

@dana-yaish dana-yaish commented Oct 5, 2023 •
edited
Loading

since node uploader supports turning file fixes off, we're doing it here too.
codecov/engineering-team#556
slack discussion for further context https://l.codecov.dev/RQNTLl

@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

Merging #276 (838b202) into master (31278f2) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
+ Coverage   94.87%   94.91%   +0.03%     
==========================================
  Files          78       78              
  Lines        2633     2634       +1     
==========================================
+ Hits         2498     2500       +2     
+ Misses        135      134       -1
Flag Coverage Δ
python3.10 95.23% <100.00%> (+0.03%) ⬆️
python3.11 95.23% <100.00%> (+0.03%) ⬆️
python3.8 95.23% <100.00%> (+0.03%) ⬆️
python3.9 95.23% <100.00%> (+0.03%) ⬆️
smart-labels 94.90% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_cli/commands/upload.py 100.00% <ø> (ø)
codecov_cli/commands/upload_process.py 90.00% <ø> (ø)
codecov_cli/services/upload/__init__.py 100.00% <ø> (ø)
codecov_cli/services/upload/upload_collector.py 83.56% <100.00%> (+1.61%) ⬆️

drazisil-codecov
drazisil-codecov approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@drazisil-codecov drazisil-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dana-yaish dana-yaish merged commit 00e49a5 into master Oct 5, 2023
10 checks passed
@dana-yaish dana-yaish deleted the dana/disable-file-fixes branch October 5, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drazisil-codecov drazisil-codecov drazisil-codecov approved these changes

@giovanni-guidini giovanni-guidini Awaiting requested review from giovanni-guidini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dana-yaish @drazisil-codecov